Commit 5a9f8df6 authored Mar 12, 2018 by Florian Fainelli Committed by David S. Miller Mar 12, 2018

net: dsa: Fix dsa_is_user_port() test inversion



During the conversion to dsa_is_user_port(), a condition ended up being
reversed, which would prevent the creation of any user port when using
the legacy binding and/or platform data, fix that.

Fixes: 4a5b85ff ("net: dsa: use dsa_is_user_port everywhere")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 59bb8835

net/dsa/legacy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -194,7 +194,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds,
		ds->ports[i].dn = cd->port_dn[i];
		ds->ports[i].cpu_dp = dst->cpu_dp;

		if (dsa_is_user_port(ds, i))
		if (!dsa_is_user_port(ds, i))
		continue;

		ret = dsa_slave_create(&ds->ports[i]);

Admin message