Commit 5a993e50 authored Nov 18, 2019 by Martin K. Petersen

Revert "scsi: qla2xxx: Fix memory leak when sending I/O fails"

This reverts commit 2f856d4e.

This patch was found to introduce a double free regression. The issue
it originally attempted to address was fixed in patch
f45bca8c ("scsi: qla2xxx: Fix double scsi_done for abort path").

Link: https://lore.kernel.org/r/4BDE2B95-835F-43BE-A32C-2629D7E03E0A@marvell.com


Requested-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 0b7a2235

drivers/scsi/qla2xxx/qla_os.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -909,8 +909,6 @@ qla2xxx_queuecommand(struct Scsi_Host host, struct scsi_cmnd cmd)

		qc24_host_busy_free_sp:
		sp->free(sp);
		CMD_SP(cmd) = NULL;
		qla2x00_rel_sp(sp);

		qc24_target_busy:
		return SCSI_MLQUEUE_TARGET_BUSY;
		@@ -994,8 +992,6 @@ qla2xxx_mqueuecommand(struct Scsi_Host host, struct scsi_cmnd cmd,

		qc24_host_busy_free_sp:
		sp->free(sp);
		CMD_SP(cmd) = NULL;
		qla2xxx_rel_qpair_sp(sp->qpair, sp);

		qc24_target_busy:
		return SCSI_MLQUEUE_TARGET_BUSY;

Admin message