Commit 5a7bb7ce authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Johannes Berg
Browse files

mac80211: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 163a7cdd

net/mac80211/debugfs_key.c

+0 −3
Original line number Diff line number Diff line
@@ -342,9 +342,6 @@ void ieee80211_debugfs_key_add(struct ieee80211_key *key) 
	key->debugfs.dir = debugfs_create_dir(buf,

					key->local->debugfs.keys);



	if (!key->debugfs.dir)

		return;



	sta = key->sta;

	if (sta) {

		sprintf(buf, "../../netdev:%s/stations/%pM",

net/mac80211/debugfs_netdev.c

+3 −7
Original line number Diff line number Diff line
@@ -818,7 +818,6 @@ void ieee80211_debugfs_add_netdev(struct ieee80211_sub_if_data *sdata) 
	sprintf(buf, "netdev:%s", sdata->name);

	sdata->vif.debugfs_dir = debugfs_create_dir(buf,

		sdata->local->hw.wiphy->debugfsdir);

	if (sdata->vif.debugfs_dir)

	sdata->debugfs.subdir_stations = debugfs_create_dir("stations",

							sdata->vif.debugfs_dir);

	add_files(sdata);
@@ -845,8 +844,5 @@ void ieee80211_debugfs_rename_netdev(struct ieee80211_sub_if_data *sdata) 
		return;



	sprintf(buf, "netdev:%s", sdata->name);

	if (!debugfs_rename(dir->d_parent, dir, dir->d_parent, buf))

		sdata_err(sdata,

			  "debugfs: failed to rename debugfs dir to %s\n",

			  buf);

	debugfs_rename(dir->d_parent, dir, dir->d_parent, buf);

}

net/mac80211/debugfs_sta.c

+0 −2
Original line number Diff line number Diff line
@@ -960,8 +960,6 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta) 
	 * dir might still be around.

	 */

	sta->debugfs_dir = debugfs_create_dir(mac, stations_dir);

	if (!sta->debugfs_dir)

		return;



	DEBUGFS_ADD(flags);

	DEBUGFS_ADD(aid);

CRA Git | Maintained and supported by SUSTech CRA and CCSE