Unverified Commit 5a7b2aab authored Jan 14, 2019 by Mark Brown

ASoC: core: Make snd_soc_find_component() more robust

There are some use cases where you're checking for a lot of things on a
card and it makes sense that you might end up trying to call
snd_soc_find_component() without either a name or an of_node. Currently
in that case we try to dereference the name and crash but it's more
useful to allow the caller to just treat that as a case where we don't
find anything, that error handling will already exist.

Inspired by a patch from Ajit Pandey fixing some callers.

Fixes: 8780cf11 ("ASoC: soc-core: defer card probe until all component is added to list")
Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 09ac6a81

sound/soc/soc-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -742,7 +742,7 @@ static struct snd_soc_component *soc_find_component(
		if (of_node) {
		if (component->dev->of_node == of_node)
		return component;
		} else if (strcmp(component->name, name) == 0) {
		} else if (name && strcmp(component->name, name) == 0) {
		return component;
		}
		}

Admin message