Commit 5a7aadfe authored Mar 26, 2010 by Matt Helsley Committed by Rafael J. Wysocki Mar 26, 2010

Freezer: Fix buggy resume test for tasks frozen with cgroup freezer

When the cgroup freezer is used to freeze tasks we do not want to thaw
those tasks during resume. Currently we test the cgroup freezer
state of the resuming tasks to see if the cgroup is FROZEN. If so
then we don't thaw the task. However, the FREEZING state also indicates
that the task should remain frozen.

This also avoids a problem pointed out by Oren Ladaan: the freezer state
transition from FREEZING to FROZEN is updated lazily when userspace reads
or writes the freezer.state file in the cgroup filesystem. This means that
resume will thaw tasks in cgroups which should be in the FROZEN state if
there is no read/write of the freezer.state file to trigger this
transition before suspend.

NOTE: Another "simple" solution would be to always update the cgroup
freezer state during resume. However it's a bad choice for several reasons:
Updating the cgroup freezer state is somewhat expensive because it requires
walking all the tasks in the cgroup and checking if they are each frozen.
Worse, this could easily make resume run in N^2 time where N is the number
of tasks in the cgroup. Finally, updating the freezer state from this code
path requires trickier locking because of the way locks must be ordered.

Instead of updating the freezer state we rely on the fact that lazy
updates only manage the transition from FREEZING to FROZEN. We know that
a cgroup with the FREEZING state may actually be FROZEN so test for that
state too. This makes sense in the resume path even for partially-frozen
cgroups -- those that really are FREEZING but not FROZEN.

Reported-by: Oren Ladaan <orenl@cs.columbia.edu>
Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
Cc: stable@kernel.org
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent 4f598458

include/linux/freezer.h

+5 −2

Original line number	Diff line number	Diff line
		@@ -64,9 +64,12 @@ extern bool freeze_task(struct task_struct *p, bool sig_only);
		extern void cancel_freezing(struct task_struct *p);

		#ifdef CONFIG_CGROUP_FREEZER
		extern int cgroup_frozen(struct task_struct *task);
		extern int cgroup_freezing_or_frozen(struct task_struct *task);
		#else /* !CONFIG_CGROUP_FREEZER */
		static inline int cgroup_frozen(struct task_struct *task) { return 0; }
		static inline int cgroup_freezing_or_frozen(struct task_struct *task)
		{
		return 0;
		}
		#endif /* !CONFIG_CGROUP_FREEZER */

		/*

kernel/cgroup_freezer.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -47,17 +47,20 @@ static inline struct freezer task_freezer(struct task_struct task)
		struct freezer, css);
		}

		int cgroup_frozen(struct task_struct *task)
		int cgroup_freezing_or_frozen(struct task_struct *task)
		{
		struct freezer *freezer;
		enum freezer_state state;

		task_lock(task);
		freezer = task_freezer(task);
		if (!freezer->css.cgroup->parent)
		state = CGROUP_THAWED; /* root cgroup can't be frozen */
		else
		state = freezer->state;
		task_unlock(task);

		return state == CGROUP_FROZEN;
		return (state == CGROUP_FREEZING) \|\| (state == CGROUP_FROZEN);
		}

		/*

kernel/power/process.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -144,7 +144,7 @@ static void thaw_tasks(bool nosig_only)
		if (nosig_only && should_send_signal(p))
		continue;

		if (cgroup_frozen(p))
		if (cgroup_freezing_or_frozen(p))
		continue;

		thaw_process(p);

Admin message