Commit 5a5bafdc authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe
Browse files

elevator: clear auxiliary data earlier during elevator switch 



Elevator switch tries hard to keep as much as context until new
elevator is ready so that it can revert to the original state if
initializing the new elevator fails for some reason.  Unfortunately,
with more auxiliary contexts to manage, this makes elevator init and
exit paths too complex and fragile.

This patch makes elevator_switch() unregister the current elevator and
flush icq's before start initializing the new one.  As we still keep
the old elevator itself, the only difference is that we lose icq's on
rare occassions of switching failure, which isn't critical at all.

Note that this makes explicit elevator parameter to
elevator_init_queue() and __elv_register_queue() unnecessary as they
always can use the current elevator.

This patch enables block cgroup cleanups.

-v2: blk_add_trace_msg() prints elevator name from @new_e instead of
     @e->type as the local variable no longer exists.  This caused
     build failure on CONFIG_BLK_DEV_IO_TRACE.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b95ada55

block/elevator.c

+45 −45
Original line number Original line Diff line number Diff line
@@ -121,11 +121,10 @@ static struct elevator_type *elevator_get(const char *name) 
	return e;

	return e;

}

}





static int elevator_init_queue(struct request_queue *q,

static int elevator_init_queue(struct request_queue *q)

			       struct elevator_queue *eq)

{

{

	eq->elevator_data = eq->type->ops.elevator_init_fn(q);

	q->elevator->elevator_data = q->elevator->type->ops.elevator_init_fn(q);

	if (eq->elevator_data)

	if (q->elevator->elevator_data)

		return 0;

		return 0;

	return -ENOMEM;

	return -ENOMEM;

}

}
@@ -188,7 +187,6 @@ static void elevator_release(struct kobject *kobj) 
int elevator_init(struct request_queue *q, char *name)

int elevator_init(struct request_queue *q, char *name)

{

{

	struct elevator_type *e = NULL;

	struct elevator_type *e = NULL;

	struct elevator_queue *eq;

	int err;

	int err;





	if (unlikely(q->elevator))

	if (unlikely(q->elevator))
@@ -222,17 +220,16 @@ int elevator_init(struct request_queue *q, char *name) 
		}

		}

	}

	}





	eq = elevator_alloc(q, e);

	q->elevator = elevator_alloc(q, e);

	if (!eq)

	if (!q->elevator)

		return -ENOMEM;

		return -ENOMEM;





	err = elevator_init_queue(q, eq);

	err = elevator_init_queue(q);

	if (err) {

	if (err) {

		kobject_put(&eq->kobj);

		kobject_put(&q->elevator->kobj);

		return err;

		return err;

	}

	}





	q->elevator = eq;

	return 0;

	return 0;

}

}

EXPORT_SYMBOL(elevator_init);

EXPORT_SYMBOL(elevator_init);
@@ -801,8 +798,9 @@ static struct kobj_type elv_ktype = { 
	.release	= elevator_release,

	.release	= elevator_release,

};

};





int __elv_register_queue(struct request_queue *q, struct elevator_queue *e)

int elv_register_queue(struct request_queue *q)

{

{

	struct elevator_queue *e = q->elevator;

	int error;

	int error;





	error = kobject_add(&e->kobj, &q->kobj, "%s", "iosched");

	error = kobject_add(&e->kobj, &q->kobj, "%s", "iosched");
@@ -820,11 +818,6 @@ int __elv_register_queue(struct request_queue *q, struct elevator_queue *e) 
	}

	}

	return error;

	return error;

}

}



int elv_register_queue(struct request_queue *q)

{

	return __elv_register_queue(q, q->elevator);

}

EXPORT_SYMBOL(elv_register_queue);

EXPORT_SYMBOL(elv_register_queue);





void elv_unregister_queue(struct request_queue *q)

void elv_unregister_queue(struct request_queue *q)
@@ -907,51 +900,58 @@ EXPORT_SYMBOL_GPL(elv_unregister); 
 */

 */

static int elevator_switch(struct request_queue *q, struct elevator_type *new_e)

static int elevator_switch(struct request_queue *q, struct elevator_type *new_e)

{

{

	struct elevator_queue *old_elevator, *e;

	struct elevator_queue *old = q->elevator;

	bool registered = old->registered;

	int err;

	int err;





	/* allocate new elevator */

	/*

	e = elevator_alloc(q, new_e);

	 * Turn on BYPASS and drain all requests w/ elevator private data.

	if (!e)

	 * Block layer doesn't call into a quiesced elevator - all requests

		return -ENOMEM;

	 * are directly put on the dispatch list without elevator data



	 * using INSERT_BACK.  All requests have SOFTBARRIER set and no

	err = elevator_init_queue(q, e);

	 * merge happens either.

	if (err) {

	 */

		kobject_put(&e->kobj);

		return err;

	}



	/* turn on BYPASS and drain all requests w/ elevator private data */

	elv_quiesce_start(q);

	elv_quiesce_start(q);





	/* unregister old queue, register new one and kill old elevator */

	/* unregister and clear all auxiliary data of the old elevator */

	if (q->elevator->registered) {

	if (registered)

		elv_unregister_queue(q);

		elv_unregister_queue(q);

		err = __elv_register_queue(q, e);

		if (err)

			goto fail_register;

	}





	/* done, clear io_cq's, switch elevators and turn off BYPASS */

	spin_lock_irq(q->queue_lock);

	spin_lock_irq(q->queue_lock);

	ioc_clear_queue(q);

	ioc_clear_queue(q);

	old_elevator = q->elevator;

	q->elevator = e;

	spin_unlock_irq(q->queue_lock);

	spin_unlock_irq(q->queue_lock);





	elevator_exit(old_elevator);

	/* allocate, init and register new elevator */

	err = -ENOMEM;

	q->elevator = elevator_alloc(q, new_e);

	if (!q->elevator)

		goto fail_init;



	err = elevator_init_queue(q);

	if (err) {

		kobject_put(&q->elevator->kobj);

		goto fail_init;

	}



	if (registered) {

		err = elv_register_queue(q);

		if (err)

			goto fail_register;

	}



	/* done, kill the old one and finish */

	elevator_exit(old);

	elv_quiesce_end(q);

	elv_quiesce_end(q);





	blk_add_trace_msg(q, "elv switch: %s", e->type->elevator_name);

	blk_add_trace_msg(q, "elv switch: %s", new_e->elevator_name);





	return 0;

	return 0;





fail_register:

fail_register:

	/*

	elevator_exit(q->elevator);

	 * switch failed, exit the new io scheduler and reattach the old

fail_init:

	 * one again (along with re-adding the sysfs dir)

	/* switch failed, restore and re-register old elevator */

	 */

	q->elevator = old;

	elevator_exit(e);

	elv_register_queue(q);

	elv_register_queue(q);

	elv_quiesce_end(q);

	elv_quiesce_end(q);

CRA Git | Maintained and supported by SUSTech CRA and CCSE