Commit 5a57c05b authored Jan 02, 2020 by Eric Sandeen Committed by Darrick J. Wong Jan 07, 2020

xfs: remove shadow variable in xfs_btree_lshift



Sparse warns about a shadow variable in this function after the
Fixed: commit added another int i; with larger scope.  It's safe
to remove the one with the smaller scope to fix this shadow,
although the shadow itself is harmless.

Fixes: 2c813ad6 ("xfs: support btrees with overlapping intervals for keys")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent b8a0880a

fs/xfs/libxfs/xfs_btree.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2389,8 +2389,6 @@ xfs_btree_lshift(
		XFS_BTREE_STATS_ADD(cur, moves, rrecs - 1);
		if (level > 0) {
		/* It's a nonleaf. operate on keys and ptrs */
		int i; /* loop index */

		for (i = 0; i < rrecs; i++) {
		error = xfs_btree_debug_check_ptr(cur, rpp, i + 1, level);
		if (error)

Admin message