[PATCH] sched: tidy up left over smpnice code (5a4f3ea7) · Commits · 戴 / test

1. The only place that RTPRIO_TO_LOAD_WEIGHT() is used is in the call to move_tasks() in the function active_load_balance() and its purpose here is just to make sure that the load to be moved is big enough to ensure that exactly one task is moved (if there's one available). This can be accomplished by using ULONG_MAX instead and this allows RTPRIO_TO_LOAD_WEIGHT() to be deleted. 2. This, in turn, allows PRIO_TO_LOAD_WEIGHT() to be deleted. 3. This allows load_weight() to be deleted which allows TIME_SLICE_NICE_ZERO to be deleted along with the comment above it. Signed-off-by:

Peter Williams <pwil3058@bigpond.net.au> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

kernel/sched.c

+1 −15

Original line number	Diff line number	Diff line
		@@ -727,19 +727,6 @@ static void update_curr_load(struct rq *rq, u64 now)
		* slice expiry etc.
		*/

		/*
		* Assume: static_prio_timeslice(NICE_TO_PRIO(0)) == DEF_TIMESLICE
		* If static_prio_timeslice() is ever changed to break this assumption then
		* this code will need modification
		*/
		#define TIME_SLICE_NICE_ZERO DEF_TIMESLICE
		#define load_weight(lp) \
		(((lp) * SCHED_LOAD_SCALE) / TIME_SLICE_NICE_ZERO)
		#define PRIO_TO_LOAD_WEIGHT(prio) \
		load_weight(static_prio_timeslice(prio))
		#define RTPRIO_TO_LOAD_WEIGHT(rp) \
		(PRIO_TO_LOAD_WEIGHT(MAX_RT_PRIO) + load_weight(rp))

		#define WEIGHT_IDLEPRIO 2
		#define WMULT_IDLEPRIO (1 << 31)

		@@ -2908,8 +2895,7 @@ static void active_load_balance(struct rq *busiest_rq, int busiest_cpu)
		schedstat_inc(sd, alb_cnt);

		if (move_tasks(target_rq, target_cpu, busiest_rq, 1,
		RTPRIO_TO_LOAD_WEIGHT(100), sd, CPU_IDLE,
		NULL))
		ULONG_MAX, sd, CPU_IDLE, NULL))
		schedstat_inc(sd, alb_pushed);
		else
		schedstat_inc(sd, alb_failed);

Admin message