Commit 5a2e3406 authored Aug 01, 2019 by Gustavo A. R. Silva Committed by Bjorn Helgaas Aug 08, 2019

PCI: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through.

This fixes the following warning (Building: allmodconfig i386):

  drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’:
  drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
	 function = 0x8;
	 ~~~~~~~~~^~~~~
  drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here
	case PCI_HEADER_TYPE_MULTIBRIDGE:
	^~~~

Link: https://lore.kernel.org/r/20190802012248.GA22622@embeddedor


Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>

parent befa45fb

drivers/pci/hotplug/ibmphp_res.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus)
		break;
		case PCI_HEADER_TYPE_BRIDGE:
		function = 0x8;
		/* fall through */
		case PCI_HEADER_TYPE_MULTIBRIDGE:
		/* We assume here that only 1 bus behind the bridge
		TO DO: add functionality for several:

Admin message