Commit 5a245750 authored Sep 08, 2017 by Christoffer Dall

KVM: arm/arm64: Remove redundant preemptible checks

The __this_cpu_read() and __this_cpu_write() functions already implement
checks for the required preemption levels when using
CONFIG_DEBUG_PREEMPT which gives you nice error messages and such.
Therefore there is no need to explicitly check this using a BUG_ON() in
the code (which we don't do for other uses of per cpu variables either).

Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>

parent 4404b336

virt/kvm/arm/arm.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -71,7 +71,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled);

		static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
		{
		BUG_ON(preemptible());
		__this_cpu_write(kvm_arm_running_vcpu, vcpu);
		}

		@@ -81,7 +80,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
		*/
		struct kvm_vcpu *kvm_arm_get_running_vcpu(void)
		{
		BUG_ON(preemptible());
		return __this_cpu_read(kvm_arm_running_vcpu);
		}

Admin message