Commit 5a23699a authored Feb 27, 2018 by Richard Fitzgerald Committed by Takashi Iwai Feb 28, 2018

ALSA: control: Fix memory corruption risk in snd_ctl_elem_read



The patch "ALSA: control: code refactoring for ELEM_READ/ELEM_WRITE
operations" introduced a potential for kernel memory corruption due
to an incorrect if statement allowing non-readable controls to fall
through and call the get function. For TLV controls a driver can omit
SNDRV_CTL_ELEM_ACCESS_READ to ensure that only the TLV get function
can be called. Instead the normal get() can be invoked unexpectedly
and as the driver expects that this will only be called for controls
<= 512 bytes, potentially try to copy >512 bytes into the 512 byte
return array, so corrupting kernel memory.

The problem is an attempt to refactor the snd_ctl_elem_read function
to invert the logic so that it conditionally aborted if the control
is unreadable instead of conditionally executing. But the if statement
wasn't inverted correctly.

The correct inversion of

    if (a && !b)

is
    if (!a || b)

Fixes: becf9e5d ("ALSA: control: code refactoring for ELEM_READ/ELEM_WRITE operations")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 71db96dd

sound/core/control.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -889,7 +889,7 @@ static int snd_ctl_elem_read(struct snd_card *card,

		index_offset = snd_ctl_get_ioff(kctl, &control->id);
		vd = &kctl->vd[index_offset];
		if (!(vd->access & SNDRV_CTL_ELEM_ACCESS_READ) && kctl->get == NULL)
		if (!(vd->access & SNDRV_CTL_ELEM_ACCESS_READ) \|\| kctl->get == NULL)
		return -EPERM;

		snd_ctl_build_ioff(&control->id, kctl, index_offset);

Admin message