lkdtm: no need to check return value of debugfs_create functions (5a2338db) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-kernel@vger.kernel.org Acked-by:

Kees Cook <keescook@chromium.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/misc/lkdtm/core.c

+2 −11

Original line number	Diff line number	Diff line
		@@ -429,22 +429,13 @@ static int __init lkdtm_module_init(void)

		/* Register debugfs interface */
		lkdtm_debugfs_root = debugfs_create_dir("provoke-crash", NULL);
		if (!lkdtm_debugfs_root) {
		pr_err("creating root dir failed\n");
		return -ENODEV;
		}

		/* Install debugfs trigger files. */
		for (i = 0; i < ARRAY_SIZE(crashpoints); i++) {
		struct crashpoint *cur = &crashpoints[i];
		struct dentry *de;

		de = debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root,
		cur, &cur->fops);
		if (de == NULL) {
		pr_err("could not create crashpoint %s\n", cur->name);
		goto out_err;
		}
		debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, cur,
		&cur->fops);
		}

		/* Install crashpoint if one was selected. */

Admin message