Commit 5a136fdf authored by NeilBrown's avatar NeilBrown Committed by Jens Axboe
Browse files

bcache: use kmalloc to allocate bio in bch_data_verify()



This function allocates a bio, then a collection
of pages.  It copes with failure.

It currently uses a mempool() to allocate the bio,
but alloc_page() to allocate the pages.  These fail
in different ways, so the usage is inconsistent.

Change the bio_clone() to bio_clone_kmalloc()
so that no pool is used either for the bio or the pages.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarKent Overstreet <kent.overstreet@gmail.com>
Reviewed-by : Ming Lei <ming.lei@redhat.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4559fa55
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio)
	struct bio_vec bv, cbv;
	struct bvec_iter iter, citer = { 0 };

	check = bio_clone(bio, GFP_NOIO);
	check = bio_clone_kmalloc(bio, GFP_NOIO);
	if (!check)
		return;
	check->bi_opf = REQ_OP_READ;