Commit 5a042aa4 authored by Jan Kara's avatar Jan Kara Committed by Jens Axboe
Browse files

mm: Cleanup clearing of BDI_pending bit in bdi_forker_thread() 



bdi_forker_thread() clears BDI_pending bit at the end of the main loop.
However clearing of this bit must not be done in some cases which is
handled by calling 'continue' from switch statement. That's kind of
unusual construct and without a good reason so change the function into
more intuitive code flow.

CC: Wu Fengguang <fengguang.wu@intel.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
parent 56ebdaf2

mm/backing-dev.c

+14 −9
Original line number Diff line number Diff line
@@ -359,6 +359,17 @@ static unsigned long bdi_longest_inactive(void) 
	return max(5UL * 60 * HZ, interval);

}



/*

 * Clear pending bit and wakeup anybody waiting for flusher thread creation or

 * shutdown

 */

static void bdi_clear_pending(struct backing_dev_info *bdi)

{

	clear_bit(BDI_pending, &bdi->state);

	smp_mb__after_clear_bit();

	wake_up_bit(&bdi->state, BDI_pending);

}



static int bdi_forker_thread(void *ptr)

{

	struct bdi_writeback *me = ptr;
@@ -469,11 +480,13 @@ static int bdi_forker_thread(void *ptr) 
				spin_unlock_bh(&bdi->wb_lock);

				wake_up_process(task);

			}

			bdi_clear_pending(bdi);

			break;



		case KILL_THREAD:

			__set_current_state(TASK_RUNNING);

			kthread_stop(task);

			bdi_clear_pending(bdi);

			break;



		case NO_ACTION:
@@ -489,16 +502,8 @@ static int bdi_forker_thread(void *ptr) 
			else

				schedule_timeout(msecs_to_jiffies(dirty_writeback_interval * 10));

			try_to_freeze();

			/* Back to the main loop */

			continue;

			break;

		}



		/*

		 * Clear pending bit and wakeup anybody waiting to tear us down.

		 */

		clear_bit(BDI_pending, &bdi->state);

		smp_mb__after_clear_bit();

		wake_up_bit(&bdi->state, BDI_pending);

	}



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE