Commit 59f4519a authored by Soeren Sandmann's avatar Soeren Sandmann Committed by Thomas Gleixner
Browse files

x86: initialize all fields of mp_irqs[mp_irq_entries] 



Commit "x86: make config_irqsrc not MPspec specific" introduced some uses
of uninitialized fields in mp_config_acpi_legacy_irqs(). I need the
following patch to get sched-devel/master to boot.

Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 2fddb6e2

arch/x86/kernel/acpi/boot.c

+4 −5
Original line number Diff line number Diff line
@@ -1012,11 +1012,6 @@ void __init mp_config_acpi_legacy_irqs(void) 
	if (ioapic < 0)

		return;



	mp_irqs[mp_irq_entries].mp_type = MP_INTSRC;

	mp_irqs[mp_irq_entries].mp_irqflag = 0;	/* Conforming */

	mp_irqs[mp_irq_entries].mp_srcbus = MP_ISA_BUS;

	mp_irqs[mp_irq_entries].mp_dstapic = mp_ioapics[ioapic].mp_apicid;



	/*

	 * Use the default configuration for the IRQs 0-15.  Unless

	 * overridden by (MADT) interrupt source override entries.
@@ -1044,6 +1039,10 @@ void __init mp_config_acpi_legacy_irqs(void) 
			continue;	/* IRQ already used */

		}



		mp_irqs[mp_irq_entries].mp_type = MP_INTSRC;

		mp_irqs[mp_irq_entries].mp_irqflag = 0;	/* Conforming */

		mp_irqs[mp_irq_entries].mp_srcbus = MP_ISA_BUS;

		mp_irqs[mp_irq_entries].mp_dstapic = mp_ioapics[ioapic].mp_apicid;

		mp_irqs[mp_irq_entries].mp_irqtype = mp_INT;

		mp_irqs[mp_irq_entries].mp_srcbusirq = i;	/* Identity mapped */

		mp_irqs[mp_irq_entries].mp_dstirq = i;

CRA Git | Maintained and supported by SUSTech CRA and CCSE