Commit 59eed279 authored Aug 25, 2006 by Stephen Hemminger Committed by David S. Miller Aug 26, 2006

[IPV6]: Segmentation offload not set correctly on TCP children

TCP over IPV6 would incorrectly inherit the GSO settings.
This would cause kernel to send Tcp Segmentation Offload packets for
IPV6 data to devices that can't handle it. It caused the sky2 driver
to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050


and the e1000 would generate bogus packets. I can't blame the
hardware for gagging if the upper layers feed it garbage.

This was a new bug in 2.6.18 introduced with GSO support.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 897522ea

net/ipv6/tcp_ipv6.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -944,7 +944,7 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock sk, struct sk_buff skb,
		* comment in that function for the gory details. -acme
		*/

		sk->sk_gso_type = SKB_GSO_TCPV6;
		newsk->sk_gso_type = SKB_GSO_TCPV6;
		__ip6_dst_store(newsk, dst, NULL);

		newtcp6sk = (struct tcp6_sock *)newsk;

Admin message