cifs: Fix sparse warning when calling cifs_strtoUCS (59edb63a) · Commits · 戴 / test

Fix sparse endian check warning while calling cifs_strtoUCS CHECK fs/cifs/smbencrypt.c fs/cifs/smbencrypt.c:216:37: warning: incorrect type in argument 1 (different base types) fs/cifs/smbencrypt.c:216:37: expected restricted __le16 [usertype] *<noident> fs/cifs/smbencrypt.c:216:37: got unsigned short *<noident> Signed-off-by:

Steve French <smfrench@gmail.com> Acked-by:

Shirish Pargaonkar <shirishpargaonkar@gmail.com>

fs/cifs/smbencrypt.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ E_md4hash(const unsigned char passwd, unsigned char p16,
		{
		int rc;
		int len;
		__u16 wpwd[129];
		__le16 wpwd[129];

		/* Password cannot be longer than 128 characters */
		if (passwd) /* Password must be converted to NT unicode */
		@@ -219,8 +219,8 @@ E_md4hash(const unsigned char passwd, unsigned char p16,
		wpwd = 0; / Ensure string is null terminated */
		}

		rc = mdfour(p16, (unsigned char ) wpwd, len sizeof(__u16));
		memset(wpwd, 0, 129 * sizeof(__u16));
		rc = mdfour(p16, (unsigned char ) wpwd, len sizeof(__le16));
		memset(wpwd, 0, 129 * sizeof(__le16));

		return rc;
		}

Admin message