Commit 59e04bc2 authored Apr 10, 2017 by Christophe JAILLET Committed by Thierry Reding Jun 15, 2017

gpu: host1x: Fix error handling



If 'devm_reset_control_get' returns an error, then we erroneously return
success because error code is taken from 'host->clk' instead of
'host->rst'.

Fixes: b386c6b7 ("gpu: host1x: Support module reset")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170410202922.17665-1-christophe.jaillet@wanadoo.fr

parent d758619b

drivers/gpu/host1x/dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -172,7 +172,7 @@ static int host1x_probe(struct platform_device *pdev)

		host->rst = devm_reset_control_get(&pdev->dev, "host1x");
		if (IS_ERR(host->rst)) {
		err = PTR_ERR(host->clk);
		err = PTR_ERR(host->rst);
		dev_err(&pdev->dev, "failed to get reset: %d\n", err);
		return err;
		}

Admin message