Commit 59aa56bf authored by Paul Gortmaker's avatar Paul Gortmaker Committed by David Vrabel
Browse files

xen: audit usages of module.h ; remove unnecessary instances 



Code that uses no modular facilities whatsoever should not be
sourcing module.h at all, since that header drags in a bunch
of other headers with it.

Similarly, code that is not explicitly using modular facilities
like module_init() but only is declaring module_param setup
variables should be using moduleparam.h and not the larger
module.h file for that.

In making this change, we also uncover an implicit use of BUG()
in inline fcns within arch/arm/include/asm/xen/hypercall.h so
we explicitly source <linux/bug.h> for that file now.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Reviewed-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
parent 4478c407

arch/arm/include/asm/xen/hypercall.h

+2 −0
Original line number Diff line number Diff line
@@ -33,6 +33,8 @@ 
#ifndef _ASM_ARM_XEN_HYPERCALL_H

#define _ASM_ARM_XEN_HYPERCALL_H



#include <linux/bug.h>



#include <xen/interface/xen.h>

#include <xen/interface/sched.h>

#include <xen/interface/platform.h>

drivers/xen/events/events_2l.c

+0 −1
Original line number Diff line number Diff line
@@ -9,7 +9,6 @@ 
#include <linux/linkage.h>

#include <linux/interrupt.h>

#include <linux/irq.h>

#include <linux/module.h>



#include <asm/sync_bitops.h>

#include <asm/xen/hypercall.h>

drivers/xen/events/events_base.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 
#include <linux/linkage.h>

#include <linux/interrupt.h>

#include <linux/irq.h>

#include <linux/module.h>

#include <linux/moduleparam.h>

#include <linux/string.h>

#include <linux/bootmem.h>

#include <linux/slab.h>

drivers/xen/events/events_fifo.c

+0 −1
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ 
#include <linux/linkage.h>

#include <linux/interrupt.h>

#include <linux/irq.h>

#include <linux/module.h>

#include <linux/smp.h>

#include <linux/percpu.h>

#include <linux/cpu.h>

drivers/xen/features.c

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ 
 */

#include <linux/types.h>

#include <linux/cache.h>

#include <linux/module.h>

#include <linux/export.h>



#include <asm/xen/hypercall.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE