Commit 599d2570 authored Dec 19, 2018 by Roi Dayan Committed by David S. Miller Dec 19, 2018

net/sched: cls_flower: Remove old entries from rhashtable



When replacing a rule we add the new rule to the rhashtable
but only remove the old if not in skip_sw.
This commit fix this and remove the old rule anyway.

Fixes: 35cc3cef ("net/sched: cls_flower: Reject duplicated rules also under skip_sw")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c6ec179a

net/sched/cls_flower.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1258,7 +1258,6 @@ static int fl_change(struct net net, struct sk_buff in_skb,
		fnew->flags \|= TCA_CLS_FLAGS_NOT_IN_HW;

		if (fold) {
		if (!tc_skip_sw(fold->flags))
		rhashtable_remove_fast(&fold->mask->ht,
		&fold->ht_node,
		fold->mask->filter_ht_params);

Admin message