Commit 5995cb7d authored Aug 16, 2007 by Eric Sandeen Committed by Tim Shimmin Sep 05, 2007

[XFS] fix nasty quota hashtable allocation bug



This git mod: 77e4635a
converted to a "greedy" allocation interface, but for the quota hashtables
it switched from allocating XFS_QM_HASHSIZE (nr of elements)
xfs_dqhash_t's to allocating only XFS_QM_HASHSIZE *bytes* - quite a lot
smaller! Then when we converted hsize "back" to nr of elements (the
division line) hsize went to 0. This was leading to oopses when running
any quota tests on the Fedora 8 test kernel, but the problem has been
there for almost a year.

SGI-PV: 968837
SGI-Modid: xfs-linux-melb:xfs-kern:29354a

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>

parent 265c1fac

fs/xfs/quota/xfs_qm.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -120,7 +120,8 @@ xfs_Gqm_init(void)
		* Initialize the dquot hash tables.
		*/
		udqhash = kmem_zalloc_greedy(&hsize,
		XFS_QM_HASHSIZE_LOW, XFS_QM_HASHSIZE_HIGH,
		XFS_QM_HASHSIZE_LOW * sizeof(xfs_dqhash_t),
		XFS_QM_HASHSIZE_HIGH * sizeof(xfs_dqhash_t),
		KM_SLEEP \| KM_MAYFAIL \| KM_LARGE);
		gdqhash = kmem_zalloc(hsize, KM_SLEEP \| KM_LARGE);
		hsize /= sizeof(xfs_dqhash_t);

Admin message