Commit 59920635 authored Dec 10, 2019 by Johan Hovold Committed by Greg Kroah-Hartman Dec 10, 2019

USB: idmouse: fix interface sanity checks



Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191210112601.3561-4-johan@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7c5a2df3

drivers/usb/misc/idmouse.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -322,7 +322,7 @@ static int idmouse_probe(struct usb_interface *interface,
		int result;

		/* check if we have gotten the data or the hid interface */
		iface_desc = &interface->altsetting[0];
		iface_desc = interface->cur_altsetting;
		if (iface_desc->desc.bInterfaceClass != 0x0A)
		return -ENODEV;

Admin message