Commit 5990baaa authored May 24, 2017 by Ihar Hrachyshka Committed by David S. Miller May 25, 2017

arp: fixed -Wuninitialized compiler warning



Commit 7d472a59 ("arp: always override
existing neigh entries with gratuitous ARP") introduced a compiler
warning:

net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in
this function [-Wmaybe-uninitialized]

While the code logic seems to be correct and doesn't allow the variable
to be used uninitialized, and the warning is not consistently
reproducible, it's still worth fixing it for other people not to waste
time looking at the warning in case it pops up in the build environment.
Yes, compiler is probably at fault, but we will need to accommodate.

Fixes: 7d472a59 ("arp: always override existing neigh entries with gratuitous ARP")
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ba615f67

net/ipv4/arp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -863,8 +863,8 @@ static int arp_process(struct net net, struct sock sk, struct sk_buff *skb)

		n = __neigh_lookup(&arp_tbl, &sip, dev, 0);

		if (n \|\| IN_DEV_ARP_ACCEPT(in_dev)) {
		addr_type = -1;
		if (n \|\| IN_DEV_ARP_ACCEPT(in_dev)) {
		is_garp = arp_is_garp(net, dev, &addr_type, arp->ar_op,
		sip, tip, sha, tha);
		}

Admin message