Commit 598c30db authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/powerplay: fix typo in mvdd table setup 

Polaris and vegam use count for the value rather than
level.  This looks like a copy paste typo from when
the code was adapted from previous asics.

I'm not sure that the SMU actually uses this value, so
I don't know that it actually is a bug per se.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=108609


Reported-by: default avatarRobert Strube <rstrube@gmail.com>
Reviewed-by: default avatarEvan Quan <evan.quan@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 083164db

drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c

+1 −1
Original line number Diff line number Diff line
@@ -655,7 +655,7 @@ static int polaris10_populate_smc_mvdd_table(struct pp_hwmgr *hwmgr, 
			count = SMU_MAX_SMIO_LEVELS;

		for (level = 0; level < count; level++) {

			table->SmioTable2.Pattern[level].Voltage =

				PP_HOST_TO_SMC_US(data->mvdd_voltage_table.entries[count].value * VOLTAGE_SCALE);

				PP_HOST_TO_SMC_US(data->mvdd_voltage_table.entries[level].value * VOLTAGE_SCALE);

			/* Index into DpmTable.Smio. Drive bits from Smio entry to get this voltage level.*/

			table->SmioTable2.Pattern[level].Smio =

				(uint8_t) level;

drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c

+1 −1
Original line number Diff line number Diff line
@@ -456,7 +456,7 @@ static int vegam_populate_smc_mvdd_table(struct pp_hwmgr *hwmgr, 
			count = SMU_MAX_SMIO_LEVELS;

		for (level = 0; level < count; level++) {

			table->SmioTable2.Pattern[level].Voltage = PP_HOST_TO_SMC_US(

					data->mvdd_voltage_table.entries[count].value * VOLTAGE_SCALE);

					data->mvdd_voltage_table.entries[level].value * VOLTAGE_SCALE);

			/* Index into DpmTable.Smio. Drive bits from Smio entry to get this voltage level.*/

			table->SmioTable2.Pattern[level].Smio =

				(uint8_t) level;

CRA Git | Maintained and supported by SUSTech CRA and CCSE