Commit 5989ad7b authored by Roman Gushchin's avatar Roman Gushchin Committed by Linus Torvalds
Browse files

mm, oom: refactor oom_kill_process() 

Patch series "introduce memory.oom.group", v2.

This is a tiny implementation of cgroup-aware OOM killer, which adds an
ability to kill a cgroup as a single unit and so guarantee the integrity
of the workload.

Although it has only a limited functionality in comparison to what now
resides in the mm tree (it doesn't change the victim task selection
algorithm, doesn't look at memory stas on cgroup level, etc), it's also
much simpler and more straightforward.  So, hopefully, we can avoid having
long debates here, as we had with the full implementation.

As it doesn't prevent any futher development, and implements an useful and
complete feature, it looks as a sane way forward.

This patch (of 2):

oom_kill_process() consists of two logical parts: the first one is
responsible for considering task's children as a potential victim and
printing the debug information.  The second half is responsible for
sending SIGKILL to all tasks sharing the mm struct with the given victim.

This commit splits oom_kill_process() with an intention to re-use the the
second half: __oom_kill_process().

The cgroup-aware OOM killer will kill multiple tasks belonging to the
victim cgroup.  We don't need to print the debug information for the each
task, as well as play with task selection (considering task's children),
so we can't use the existing oom_kill_process().

Link: http://lkml.kernel.org/r/20171130152824.1591-2-guro@fb.com
Link: http://lkml.kernel.org/r/20180802003201.817-3-guro@fb.com


Signed-off-by: default avatarRoman Gushchin <guro@fb.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Rientjes <rientjes@google.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1caed860

mm/oom_kill.c

+65 −58
Original line number Diff line number Diff line
@@ -829,68 +829,12 @@ static bool task_will_free_mem(struct task_struct *task) 
	return ret;

}



static void oom_kill_process(struct oom_control *oc, const char *message)

static void __oom_kill_process(struct task_struct *victim)

{

	struct task_struct *p = oc->chosen;

	unsigned int points = oc->chosen_points;

	struct task_struct *victim = p;

	struct task_struct *child;

	struct task_struct *t;

	struct task_struct *p;

	struct mm_struct *mm;

	unsigned int victim_points = 0;

	static DEFINE_RATELIMIT_STATE(oom_rs, DEFAULT_RATELIMIT_INTERVAL,

					      DEFAULT_RATELIMIT_BURST);

	bool can_oom_reap = true;



	/*

	 * If the task is already exiting, don't alarm the sysadmin or kill

	 * its children or threads, just give it access to memory reserves

	 * so it can die quickly

	 */

	task_lock(p);

	if (task_will_free_mem(p)) {

		mark_oom_victim(p);

		wake_oom_reaper(p);

		task_unlock(p);

		put_task_struct(p);

		return;

	}

	task_unlock(p);



	if (__ratelimit(&oom_rs))

		dump_header(oc, p);



	pr_err("%s: Kill process %d (%s) score %u or sacrifice child\n",

		message, task_pid_nr(p), p->comm, points);



	/*

	 * If any of p's children has a different mm and is eligible for kill,

	 * the one with the highest oom_badness() score is sacrificed for its

	 * parent.  This attempts to lose the minimal amount of work done while

	 * still freeing memory.

	 */

	read_lock(&tasklist_lock);

	for_each_thread(p, t) {

		list_for_each_entry(child, &t->children, sibling) {

			unsigned int child_points;



			if (process_shares_mm(child, p->mm))

				continue;

			/*

			 * oom_badness() returns 0 if the thread is unkillable

			 */

			child_points = oom_badness(child,

				oc->memcg, oc->nodemask, oc->totalpages);

			if (child_points > victim_points) {

				put_task_struct(victim);

				victim = child;

				victim_points = child_points;

				get_task_struct(victim);

			}

		}

	}

	read_unlock(&tasklist_lock);



	p = find_lock_task_mm(victim);

	if (!p) {

		put_task_struct(victim);
@@ -964,6 +908,69 @@ static void oom_kill_process(struct oom_control *oc, const char *message) 
}

#undef K



static void oom_kill_process(struct oom_control *oc, const char *message)

{

	struct task_struct *p = oc->chosen;

	unsigned int points = oc->chosen_points;

	struct task_struct *victim = p;

	struct task_struct *child;

	struct task_struct *t;

	unsigned int victim_points = 0;

	static DEFINE_RATELIMIT_STATE(oom_rs, DEFAULT_RATELIMIT_INTERVAL,

					      DEFAULT_RATELIMIT_BURST);



	/*

	 * If the task is already exiting, don't alarm the sysadmin or kill

	 * its children or threads, just give it access to memory reserves

	 * so it can die quickly

	 */

	task_lock(p);

	if (task_will_free_mem(p)) {

		mark_oom_victim(p);

		wake_oom_reaper(p);

		task_unlock(p);

		put_task_struct(p);

		return;

	}

	task_unlock(p);



	if (__ratelimit(&oom_rs))

		dump_header(oc, p);



	pr_err("%s: Kill process %d (%s) score %u or sacrifice child\n",

		message, task_pid_nr(p), p->comm, points);



	/*

	 * If any of p's children has a different mm and is eligible for kill,

	 * the one with the highest oom_badness() score is sacrificed for its

	 * parent.  This attempts to lose the minimal amount of work done while

	 * still freeing memory.

	 */

	read_lock(&tasklist_lock);

	for_each_thread(p, t) {

		list_for_each_entry(child, &t->children, sibling) {

			unsigned int child_points;



			if (process_shares_mm(child, p->mm))

				continue;

			/*

			 * oom_badness() returns 0 if the thread is unkillable

			 */

			child_points = oom_badness(child,

				oc->memcg, oc->nodemask, oc->totalpages);

			if (child_points > victim_points) {

				put_task_struct(victim);

				victim = child;

				victim_points = child_points;

				get_task_struct(victim);

			}

		}

	}

	read_unlock(&tasklist_lock);



	__oom_kill_process(victim);

}



/*

 * Determines whether the kernel must panic because of the panic_on_oom sysctl.

 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE