Commit 596efe47 authored by Paul Walmsley's avatar Paul Walmsley
Browse files

OMAP3: control/PM: move padconf save code to mach-omap2/control.c 



Move the padconf save code from pm34xx.c to the System Control Module
code in mach-omap2/control.c.  This is part of the general push to
move direct register access from middle-layer core code to low-level
core code, so the middle-layer code can be abstracted to work on
multiple platforms and cleaned up.

In the medium-to-long term, this code should be called by the mux
layer code, not the PM idle code.  This is because, according to the
TRM, saving the padconf only needs to be done when the padconf
changes[1].

Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Tony Lindgren <tony@atomide.com>
Tested-by: default avatarRajendra Nayak <rnayak@ti.com>
Tested-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>

1. OMAP34xx Multimedia Device Silicon Revision 3.1.x [Rev. ZH] [SWPU222H]
   Section 4.11.4 "Device Off-Mode Sequences"
parent 72e06d08

arch/arm/mach-omap2/control.c

+31 −0
Original line number Diff line number Diff line
@@ -26,6 +26,10 @@ 
#include "pm.h"

#include "control.h"



/* Used by omap3_ctrl_save_padconf() */

#define START_PADCONF_SAVE		0x2

#define PADCONF_SAVE_DONE		0x1



static void __iomem *omap2_ctrl_base;

static void __iomem *omap4_ctrl_pad_base;
@@ -530,4 +534,31 @@ void omap3630_ctrl_disable_rta(void) 
	omap_ctrl_writel(OMAP36XX_RTA_DISABLE, OMAP36XX_CONTROL_MEM_RTA_CTRL);

}



/**

 * omap3_ctrl_save_padconf - save padconf registers to scratchpad RAM

 *

 * Tell the SCM to start saving the padconf registers, then wait for

 * the process to complete.  Returns 0 unconditionally, although it

 * should also eventually be able to return -ETIMEDOUT, if the save

 * does not complete.

 *

 * XXX This function is missing a timeout.  What should it be?

 */

int omap3_ctrl_save_padconf(void)

{

	u32 cpo;



	/* Save the padconf registers */

	cpo = omap_ctrl_readl(OMAP343X_CONTROL_PADCONF_OFF);

	cpo |= START_PADCONF_SAVE;

	omap_ctrl_writel(cpo, OMAP343X_CONTROL_PADCONF_OFF);



	/* wait for the save to complete */

	while (!(omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)

		 & PADCONF_SAVE_DONE))

		udelay(1);



	return 0;

}



#endif /* CONFIG_ARCH_OMAP3 && CONFIG_PM */

arch/arm/mach-omap2/control.h

+1 −0
Original line number Diff line number Diff line
@@ -359,6 +359,7 @@ extern void omap3_control_save_context(void); 
extern void omap3_control_restore_context(void);

extern void omap3_ctrl_write_boot_mode(u8 bootmode);

extern void omap3630_ctrl_disable_rta(void);

extern int omap3_ctrl_save_padconf(void);

#else

#define omap_ctrl_base_get()		0

#define omap_ctrl_readb(x)		0

arch/arm/mach-omap2/pm34xx.c

+1 −10
Original line number Diff line number Diff line
@@ -133,16 +133,7 @@ static void omap3_disable_io_chain(void) 


static void omap3_core_save_context(void)

{

	u32 control_padconf_off;



	/* Save the padconf registers */

	control_padconf_off = omap_ctrl_readl(OMAP343X_CONTROL_PADCONF_OFF);

	control_padconf_off |= START_PADCONF_SAVE;

	omap_ctrl_writel(control_padconf_off, OMAP343X_CONTROL_PADCONF_OFF);

	/* wait for the save to complete */

	while (!(omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)

			& PADCONF_SAVE_DONE))

		udelay(1);

	omap3_ctrl_save_padconf();



	/*

	 * Force write last pad into memory, as this can fail in some

arch/arm/plat-omap/include/plat/prcm.h

+0 −3
Original line number Diff line number Diff line
@@ -32,9 +32,6 @@ void omap_prcm_arch_reset(char mode, const char *cmd); 
int omap2_cm_wait_idlest(void __iomem *reg, u32 mask, u8 idlest,

			 const char *name);



#define START_PADCONF_SAVE 0x2

#define PADCONF_SAVE_DONE  0x1



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE