checkpatch: improve the STORAGE_CLASS test (596ed45b) · Commits · 戴 / test

Make sure static, extern, and asmlinkage appear before a specific type. e.g.: int asmlinkage foo(void) is better written asmlinkage int foo(void) Link: http://lkml.kernel.org/r/31704c96df2d5fd9df0b41165940a7a4feb16a63.1499284835.git.joe@perches.com Signed-off-by:

scripts/checkpatch.pl

+10 −2

Original line number	Diff line number	Diff line
		@@ -5576,10 +5576,18 @@ sub process {
		"architecture specific defines should be avoided\n" . $herecurr);
		}

		# check that the storage class is not after a type
		if ($line =~ /\b($Type)\s+($Storage)\b/) {
		WARN("STORAGE_CLASS",
		"storage class '$2' should be located before type '$1'\n" . $herecurr);
		}
		# Check that the storage class is at the beginning of a declaration
		if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
		if ($line =~ /\b$Storage\b/ &&
		$line !~ /^.\s*$Storage/ &&
		$line =~ /^.\s*(.+?)\$Storage\s/ &&
		$1 !~ /[\,\)]\s*$/) {
		WARN("STORAGE_CLASS",
		"storage class should be at the beginning of the declaration\n" . $herecurr)
		"storage class should be at the beginning of the declaration\n" . $herecurr);
		}

		# check the location of the inline attribute, that it is between