Commit 59534b9d authored Oct 13, 2019 by Israel Rukshin Committed by Jens Axboe Nov 04, 2019

nvmet-rdma: add unlikely check at nvmet_rdma_map_sgl_keyed



The calls to nvmet_req_alloc_sgl and rdma_rw_ctx_init should usually
succeed, so add this simple optimization to the fast path.

Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent e522f446

drivers/nvme/target/rdma.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -672,13 +672,13 @@ static u16 nvmet_rdma_map_sgl_keyed(struct nvmet_rdma_rsp *rsp,
		return 0;

		ret = nvmet_req_alloc_sgl(&rsp->req);
		if (ret < 0)
		if (unlikely(ret < 0))
		goto error_out;

		ret = rdma_rw_ctx_init(&rsp->rw, cm_id->qp, cm_id->port_num,
		rsp->req.sg, rsp->req.sg_cnt, 0, addr, key,
		nvmet_data_dir(&rsp->req));
		if (ret < 0)
		if (unlikely(ret < 0))
		goto error_out;
		rsp->n_rdma += ret;

Admin message