Commit 5925a055 authored Jul 02, 2014 by Eric Dumazet Committed by David S. Miller Jul 02, 2014

net: fix sparse warning in sk_dst_set()

sk_dst_cache has __rcu annotation, so we need a cast to avoid
following sparse error :

include/net/sock.h:1774:19: warning: incorrect type in initializer (different address spaces)
include/net/sock.h:1774:19: expected struct dst_entry [noderef] <asn:4>*__ret
include/net/sock.h:1774:19: got struct dst_entry *dst

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 7f502361 ("ipv4: irq safe sk_dst_[re]set() and ipv4_sk_update_pmtu() fix")
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a48e5faf

include/net/sock.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -1771,7 +1771,7 @@ sk_dst_set(struct sock sk, struct dst_entry dst)
		struct dst_entry *old_dst;

		sk_tx_queue_clear(sk);
		old_dst = xchg(&sk->sk_dst_cache, dst);
		old_dst = xchg((__force struct dst_entry **)&sk->sk_dst_cache, dst);
		dst_release(old_dst);
		}

Admin message