Commit 591c39ff authored May 13, 2019 by Dan Carpenter Committed by Zhenyu Wang May 21, 2019

drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()

"ret" is uninitialized on this path but it should be -EINVAL.

Fixes: 930c8dfe ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>

parent e175a252

drivers/gpu/drm/i915/gvt/gtt.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
		} else {
		int type = get_next_pt_type(we->type);

		if (!gtt_type_is_pt(type))
		if (!gtt_type_is_pt(type)) {
		ret = -EINVAL;
		goto err;
		}

		spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
		if (IS_ERR(spt)) {