Commit 59136aa3 authored Aug 11, 2020 by Florian Westphal Committed by Pablo Neira Ayuso Aug 13, 2020

netfilter: nf_tables: free chain context when BINDING flag is missing



syzbot found a memory leak in nf_tables_addchain() because the chain
object is not free'd correctly on error.

Fixes: d0e2c7de ("netfilter: nf_tables: add NFT_CHAIN_BINDING")
Reported-by:  <syzbot+c99868fde67014f7e9f5@syzkaller.appspotmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 2404b73c

net/netfilter/nf_tables_api.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2018,8 +2018,10 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,
		if (nla[NFTA_CHAIN_NAME]) {
		chain->name = nla_strdup(nla[NFTA_CHAIN_NAME], GFP_KERNEL);
		} else {
		if (!(flags & NFT_CHAIN_BINDING))
		return -EINVAL;
		if (!(flags & NFT_CHAIN_BINDING)) {
		err = -EINVAL;
		goto err1;
		}

		snprintf(name, sizeof(name), "__chain%llu", ++chain_id);
		chain->name = kstrdup(name, GFP_KERNEL);

Admin message