Commit 58fc90fd authored Feb 21, 2020 by Kajol Jain Committed by Arnaldo Carvalho de Melo Mar 24, 2020

perf metricgroup: Fix printing event names of metric group with multiple...


perf metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

Commit f01642e4 ("perf metricgroup: Support multiple events for
metricgroup") introduced support for multiple events in a metric group.
But with the current upstream, metric events names are not printed
properly incase we try to run multiple metric groups with overlapping
event.

With current upstream version, incase of overlapping metric events issue
is, we always start our comparision logic from start.  So, the events
which already matched with some metric group also take part in
comparision logic. Because of that when we have overlapping events, we
end up matching current metric group event with already matched one.

For example, in skylake machine we have metric event CoreIPC and
Instructions. Both of them need 'inst_retired.any' event value.  As
events in Instructions is subset of events in CoreIPC, they endup in
pointing to same 'inst_retired.any' value.

In skylake platform:

command:# ./perf stat -M CoreIPC,Instructions  -C 0 sleep 1

 Performance counter stats for 'CPU(s) 0':

     1,254,992,790      inst_retired.any          # 1254992790.0
                                                    Instructions
                                                  #      1.3 CoreIPC
       977,172,805      cycles
     1,254,992,756      inst_retired.any

       1.000802596 seconds time elapsed

command:# sudo ./perf stat -M UPI,IPC sleep 1

   Performance counter stats for 'sleep 1':
           948,650      uops_retired.retire_slots
           866,182      inst_retired.any          #      0.7 IPC
           866,182      inst_retired.any
         1,175,671      cpu_clk_unhalted.thread

Patch fixes the issue by adding a new bool pointer 'evlist_used' to keep
track of events which already matched with some group by setting it
true.  So, we skip all used events in list when we start comparision
logic.  Patch also make some changes in comparision logic, incase we get
a match miss, we discard the whole match and start again with first
event id in metric event.

With this patch:

In skylake platform:

command:# ./perf stat -M CoreIPC,Instructions  -C 0 sleep 1

 Performance counter stats for 'CPU(s) 0':

         3,348,415      inst_retired.any          #      0.3 CoreIPC
        11,779,026      cycles
         3,348,381      inst_retired.any          # 3348381.0
                                                    Instructions

       1.001649056 seconds time elapsed

command:# ./perf stat -M UPI,IPC sleep 1

 Performance counter stats for 'sleep 1':

         1,023,148      uops_retired.retire_slots #      1.1 UPI
           924,976      inst_retired.any
           924,976      inst_retired.any          #      0.6 IPC
         1,489,414      cpu_clk_unhalted.thread

       1.003064672 seconds time elapsed

Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Link: http://lore.kernel.org/lkml/20200221101121.28920-1-kjain@linux.ibm.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent d13e9e41

tools/perf/util/metricgroup.c

+30 −19

Original line number	Diff line number	Diff line
		@@ -95,13 +95,16 @@ struct egroup {
		static struct evsel find_evsel_group(struct evlist perf_evlist,
		const char **ids,
		int idnum,
		struct evsel **metric_events)
		struct evsel **metric_events,
		bool *evlist_used)
		{
		struct evsel *ev;
		int i = 0;
		int i = 0, j = 0;
		bool leader_found;

		evlist__for_each_entry (perf_evlist, ev) {
		if (evlist_used[j++])
		continue;
		if (!strcmp(ev->name, ids[i])) {
		if (!metric_events[i])
		metric_events[i] = ev;
		@@ -109,22 +112,17 @@ static struct evsel find_evsel_group(struct evlist perf_evlist,
		if (i == idnum)
		break;
		} else {
		if (i + 1 == idnum) {
		/* Discard the whole match and start again */
		i = 0;
		memset(metric_events, 0,
		sizeof(struct evsel ) idnum);
		continue;
		}

		if (!strcmp(ev->name, ids[i]))
		if (!strcmp(ev->name, ids[i])) {
		if (!metric_events[i])
		metric_events[i] = ev;
		else {
		/* Discard the whole match and start again */
		i = 0;
		memset(metric_events, 0,
		sizeof(struct evsel ) idnum);
		continue;
		i++;
		if (i == idnum)
		break;
		}
		}
		}
		@@ -146,7 +144,10 @@ static struct evsel find_evsel_group(struct evlist perf_evlist,
		!strcmp(ev->name, metric_events[i]->name)) {
		ev->metric_leader = metric_events[i];
		}
		j++;
		}
		ev = metric_events[i];
		evlist_used[ev->idx] = true;
		}

		return metric_events[0];
		@@ -162,6 +163,13 @@ static int metricgroup__setup_events(struct list_head *groups,
		int ret = 0;
		struct egroup *eg;
		struct evsel *evsel;
		bool *evlist_used;

		evlist_used = calloc(perf_evlist->core.nr_entries, sizeof(bool));
		if (!evlist_used) {
		ret = -ENOMEM;
		return ret;
		}

		list_for_each_entry (eg, groups, nd) {
		struct evsel **metric_events;
		@@ -172,7 +180,7 @@ static int metricgroup__setup_events(struct list_head *groups,
		break;
		}
		evsel = find_evsel_group(perf_evlist, eg->ids, eg->idnum,
		metric_events);
		metric_events, evlist_used);
		if (!evsel) {
		pr_debug("Cannot resolve %s: %s\n",
		eg->metric_name, eg->metric_expr);
		@@ -196,6 +204,9 @@ static int metricgroup__setup_events(struct list_head *groups,
		expr->metric_events = metric_events;
		list_add(&expr->nd, &me->head);
		}

		free(evlist_used);

		return ret;
		}

Admin message