Commit 58ed68b5 authored Sep 18, 2020 by Dan Carpenter Committed by David S. Miller Sep 21, 2020

sfc: Fix error code in probe



This failure path should return a negative error code but it currently
returns success.

Fixes: 51b35a45 ("sfc: skeleton EF100 PF driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e1b81391

drivers/net/ethernet/sfc/ef100.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -490,6 +490,7 @@ static int ef100_pci_probe(struct pci_dev *pci_dev,
		if (fcw.offset > pci_resource_len(efx->pci_dev, fcw.bar) - ESE_GZ_FCW_LEN) {
		netif_err(efx, probe, efx->net_dev,
		"Func control window overruns BAR\n");
		rc = -EIO;
		goto fail;
		}

Admin message