Commit 58e20770 authored Apr 29, 2012 by Dave Chinner Committed by Ben Myers May 14, 2012

xfs: don't assert on delalloc regions beyond EOF



When we are doing speculative delayed allocation beyond EOF,
conversion of the region allocated beyond EOF is dependent on the
largest free space extent available. If the largest free extent is
smaller than the delalloc range, then after allocation we leave
a delalloc extent that starts beyond EOF. This extent cannot *ever*
be converted by flushing data, and so will remain there until either
the EOF moves into the extent or it is truncated away.

Hence if xfs_getbmap() runs on such an inode and is asked to return
extents beyond EOF, it will assert fail on this extent even though
there is nothing xfs_getbmap() can do to convert it to a real
extent. Hence we should simply report these delalloc extents rather
than assert that there should be none.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

parent 81158e0c

fs/xfs/xfs_bmap.c

+14 −2

Original line number	Diff line number	Diff line
		@@ -5621,8 +5621,20 @@ xfs_getbmap(
		XFS_FSB_TO_BB(mp, map[i].br_blockcount);
		out[cur_ext].bmv_unused1 = 0;
		out[cur_ext].bmv_unused2 = 0;
		ASSERT(((iflags & BMV_IF_DELALLOC) != 0) \|\|
		(map[i].br_startblock != DELAYSTARTBLOCK));

		/*
		* delayed allocation extents that start beyond EOF can
		* occur due to speculative EOF allocation when the
		* delalloc extent is larger than the largest freespace
		* extent at conversion time. These extents cannot be
		* converted by data writeback, so can exist here even
		* if we are not supposed to be finding delalloc
		* extents.
		*/
		if (map[i].br_startblock == DELAYSTARTBLOCK &&
		map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
		ASSERT((iflags & BMV_IF_DELALLOC) != 0);

		if (map[i].br_startblock == HOLESTARTBLOCK &&
		whichfork == XFS_ATTR_FORK) {
		/* came to the end of attribute fork */

Admin message