Commit 58db5785 authored Jul 16, 2020 by Colin Ian King Committed by Paul E. McKenney Aug 24, 2020

refperf: Avoid null pointer dereference when buf fails to allocate

Currently in the unlikely event that buf fails to be allocated it
is dereferenced a few times. Use the errexit flag to determine if
buf should be written to to avoid the null pointer dereferences.

Addresses-Coverity: ("Dereference after null check")
Fixes: f518f154 ("refperf: Dynamically allocate experiment-summary output buffer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 57f60202

kernel/rcu/refscale.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -546,9 +546,11 @@ static int main_func(void *arg)
		// Print the average of all experiments
		SCALEOUT("END OF TEST. Calculating average duration per loop (nanoseconds)...\n");

		if (!errexit) {
		buf[0] = 0;
		strcat(buf, "\n");
		strcat(buf, "Runs\tTime(ns)\n");
		}

		for (exp = 0; exp < nruns; exp++) {
		u64 avg;

Admin message