Commit 58aff0af authored Sep 18, 2017 by Will Deacon Committed by Al Viro Sep 20, 2017

ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user



Commit 553f770e ("ipc: move compat shmctl to native") moved the
compat IPC syscall handling into ipc/shm.c and refactored the struct
accessors in the process. Unfortunately, the call to
copy_compat_shmid_to_user when handling a compat {IPC,SHM}_STAT command
gets the arguments the wrong way round, passing a kernel stack address
as the user buffer (destination) and the user buffer as the kernel stack
address (source).

This patch fixes the parameter ordering so the buffers are accessed
correctly.

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent a90bcb86

ipc/shm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1237,7 +1237,7 @@ COMPAT_SYSCALL_DEFINE3(shmctl, int, shmid, int, cmd, void __user *, uptr)
		err = shmctl_stat(ns, shmid, cmd, &sem64);
		if (err < 0)
		return err;
		if (copy_compat_shmid_to_user(&sem64, uptr, version))
		if (copy_compat_shmid_to_user(uptr, &sem64, version))
		err = -EFAULT;
		return err;

Admin message