Commit 58a2ddae authored by David Sterba's avatar David Sterba
Browse files

btrfs: add assertion helpers for extent buffer read lock counters 



The read_locks are a simple counter to track locking balance and used to
assert tree locks.  Add helpers to make it conditionally work only in
DEBUG builds.  Will be used in followup patches.

Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent afd495a8

fs/btrfs/locking.c

+18 −7
Original line number Diff line number Diff line
@@ -12,8 +12,6 @@ 
#include "extent_io.h"

#include "locking.h"



static void btrfs_assert_tree_read_locked(struct extent_buffer *eb);



#ifdef CONFIG_BTRFS_DEBUG

static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb)

{
@@ -43,12 +41,30 @@ static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) 
	atomic_dec(&eb->spinning_readers);

}



static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb)

{

	atomic_inc(&eb->read_locks);

}



static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb)

{

	atomic_dec(&eb->read_locks);

}



static void btrfs_assert_tree_read_locked(struct extent_buffer *eb)

{

	BUG_ON(!atomic_read(&eb->read_locks));

}



#else

static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { }

static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { }

static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) { }

static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) { }

static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { }

static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) { }

static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) { }

static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) { }

#endif



void btrfs_set_lock_blocking_read(struct extent_buffer *eb)
@@ -309,8 +325,3 @@ void btrfs_assert_tree_locked(struct extent_buffer *eb) 
{

	BUG_ON(!atomic_read(&eb->write_locks));

}
 


static void btrfs_assert_tree_read_locked(struct extent_buffer *eb)

{

	BUG_ON(!atomic_read(&eb->read_locks));

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE