Commit 5895d311 authored Feb 11, 2019 by Sven Van Asbroeck Committed by Felipe Balbi Feb 13, 2019

usb: phy: twl6030-usb: fix possible use-after-free on remove

In remove(), use cancel_delayed_work_sync() to cancel the
delayed work. Otherwise there's a chance that this work
will continue to run until after the device has been removed.

This issue was detected with the help of Coccinelle.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Bin Liu <b-liu@ti.com>
Fixes: b6a619a8 ("usb: phy: Check initial state for twl6030")
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 0d1ec194

drivers/usb/phy/phy-twl6030-usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -400,7 +400,7 @@ static int twl6030_usb_remove(struct platform_device *pdev)
		{
		struct twl6030_usb *twl = platform_get_drvdata(pdev);

		cancel_delayed_work(&twl->get_status_work);
		cancel_delayed_work_sync(&twl->get_status_work);
		twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,
		REG_INT_MSK_LINE_C);
		twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,

Admin message