Commit 58828680 authored Jun 22, 2017 by Colin Ian King Committed by Kalle Valo Jun 28, 2017

rsi: add in missing RSI_FSM_STATES into array fsm_state



Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED
and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state
was not updated to match. This can lead to an array overrun when
accessing the latter two states in fsm_state. Fix this by adding in
the missing states.

Detected by CoverityScan, CID#1398379 ("Illegal address computation")

Fixes: 9920322c ("rsi: add tx frame for common device configuration")
Fixes: 015e3674 ("rsi: Register interrupt handler before firmware load")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 21394d57

drivers/net/wireless/rsi/rsi_91x_debugfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -125,7 +125,9 @@ static int rsi_stats_read(struct seq_file seq, void data)
		struct rsi_common *common = seq->private;

		unsigned char fsm_state[][32] = {
		"FSM_FW_NOT_LOADED",
		"FSM_CARD_NOT_READY",
		"FSM_COMMON_DEV_PARAMS_SENT",
		"FSM_BOOT_PARAMS_SENT",
		"FSM_EEPROM_READ_MAC_ADDR",
		"FSM_RESET_MAC_SENT",

Admin message