net/smc: cleanup listen worker mutex unlocking (587e41dc) · Commits · 戴 / test

For easier reading move the unlock of mutex smc_create_lgr_pending into smc_listen_work(), i.e. into the function the mutex has been locked. No functional change. Reported-by:

Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:

Ursula Braun <ubraun@linux.ibm.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/smc/af_smc.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1182,7 +1182,6 @@ static int smc_listen_rdma_finish(struct smc_sock *new_smc,
		return 0;

		decline:
		mutex_unlock(&smc_create_lgr_pending);
		smc_listen_decline(new_smc, reason_code, local_contact);
		return reason_code;
		}
		@@ -1282,9 +1281,11 @@ static void smc_listen_work(struct work_struct *work)

		/* finish worker */
		if (!ism_supported) {
		if (smc_listen_rdma_finish(new_smc, &cclc, local_contact))
		if (smc_listen_rdma_finish(new_smc, &cclc, local_contact)) {
		mutex_unlock(&smc_create_lgr_pending);
		return;
		}
		}
		smc_conn_save_peer_info(new_smc, &cclc);
		mutex_unlock(&smc_create_lgr_pending);
		smc_listen_out_connected(new_smc);

Admin message