Commit 58556104 authored Aug 11, 2014 by David S. Miller

sparc64: Do not disable interrupts in nmi_cpu_busy()



nmi_cpu_busy() is a SMP function call that just makes sure that all of the
cpus are spinning using cpu cycles while the NMI test runs.

It does not need to disable IRQs because we just care about NMIs executing
which will even with 'normal' IRQs disabled.

It is not legal to enable hard IRQs in a SMP cross call, in fact this bug
triggers the BUG check in irq_work_run_list():

	BUG_ON(!irqs_disabled());

Because now irq_work_run() is invoked from the tail of
generic_smp_call_function_single_interrupt().

Signed-off-by: David S. Miller <davem@davemloft.net>

parent caa9199b

arch/sparc/kernel/nmi.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -130,7 +130,6 @@ static inline unsigned int get_nmi_count(int cpu)

		static __init void nmi_cpu_busy(void *data)
		{
		local_irq_enable_in_hardirq();
		while (endflag == 0)
		mb();
		}

Admin message