Commit 584d7aad authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION 



Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're wrongly
shifting the SAM_STAT_CHECK_CONDITION by one instead of directly ORing it
onto the SCSI command's result.

Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reported-by: default avatarBart Van Assche <Bart.VanAssche@wdc.com>
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f7d5182c

drivers/scsi/qla2xxx/qla_isr.c

+3 −3
Original line number Diff line number Diff line
@@ -2174,7 +2174,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) 
		    0x10, 0x1);

		set_driver_byte(cmd, DRIVER_SENSE);

		set_host_byte(cmd, DID_ABORT);

		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;

		cmd->result |= SAM_STAT_CHECK_CONDITION;

		return 1;

	}
@@ -2184,7 +2184,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) 
		    0x10, 0x3);

		set_driver_byte(cmd, DRIVER_SENSE);

		set_host_byte(cmd, DID_ABORT);

		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;

		cmd->result |= SAM_STAT_CHECK_CONDITION;

		return 1;

	}
@@ -2194,7 +2194,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) 
		    0x10, 0x2);

		set_driver_byte(cmd, DRIVER_SENSE);

		set_host_byte(cmd, DID_ABORT);

		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;

		cmd->result |= SAM_STAT_CHECK_CONDITION;

		return 1;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE