RDS: RDMA: return appropriate error on rdma map failures (584a8279) · Commits · 戴 / test

The first message to a remote node should prompt a new connection even if it is RDMA operation. For RDMA operation the MR mapping can fail because connections is not yet up. Since the connection establishment is asynchronous, we make sure the map failure because of unavailable connection reach to the user by appropriate error code. Before returning to the user, lets trigger the connection so that its ready for the next retry. Signed-off-by:

Santosh Shilimkar <santosh.shilimkar@oracle.com>

net/rds/send.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -945,6 +945,11 @@ static int rds_cmsg_send(struct rds_sock rs, struct rds_message rm,
		ret = rds_cmsg_rdma_map(rs, rm, cmsg);
		if (!ret)
		*allocated_mr = 1;
		else if (ret == -ENODEV)
		/* Accommodate the get_mr() case which can fail
		* if connection isn't established yet.
		*/
		ret = -EAGAIN;
		break;
		case RDS_CMSG_ATOMIC_CSWP:
		case RDS_CMSG_ATOMIC_FADD:
		@@ -1082,8 +1087,12 @@ int rds_sendmsg(struct socket sock, struct msghdr msg, size_t payload_len)

		/* Parse any control messages the user may have included. */
		ret = rds_cmsg_send(rs, rm, msg, &allocated_mr);
		if (ret)
		if (ret) {
		/* Trigger connection so that its ready for the next retry */
		if (ret == -EAGAIN)
		rds_conn_connect_if_down(conn);
		goto out;
		}

		if (rm->rdma.op_active && !conn->c_trans->xmit_rdma) {
		printk_ratelimited(KERN_NOTICE "rdma_op %p conn xmit_rdma %p\n",

Admin message