Commit 58420016 authored Nov 13, 2014 by Joonsoo Kim Committed by Linus Torvalds Nov 13, 2014

mm/compaction: skip the range until proper target pageblock is met



Commit 7d49d886 ("mm, compaction: reduce zone checking frequency in
the migration scanner") has a side-effect that changes the iteration
range calculation.  Before the change, block_end_pfn is calculated using
start_pfn, but now it blindly adds pageblock_nr_pages to the previous
value.

This causes the problem that isolation_start_pfn is larger than
block_end_pfn when we isolate the page with more than pageblock order.
In this case, isolation would fail due to an invalid range parameter.

To prevent this, this patch implements skipping the range until a proper
target pageblock is met.  Without this patch, CMA with more than
pageblock order always fails but with this patch it will succeed.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Michal Nazarewicz <mina86@mina86.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c4065152

mm/compaction.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -479,6 +479,16 @@ isolate_freepages_range(struct compact_control *cc,

		block_end_pfn = min(block_end_pfn, end_pfn);

		/*
		* pfn could pass the block_end_pfn if isolated freepage
		* is more than pageblock order. In this case, we adjust
		* scanning range to right one.
		*/
		if (pfn >= block_end_pfn) {
		block_end_pfn = ALIGN(pfn + 1, pageblock_nr_pages);
		block_end_pfn = min(block_end_pfn, end_pfn);
		}

		if (!pageblock_pfn_to_page(pfn, block_end_pfn, cc->zone))
		break;

Admin message