Commit 58364c50 authored Oct 31, 2017 by Mauro Carvalho Chehab

media: atomisp: make function calls cleaner

The #ifs inside the code makes confusing for reviewers and also
cause problems with smatch:
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c:2937:1: error: directive in argument list
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c:2939:1: error: directive in argument list
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c:2941:1: error: directive in argument list

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>

parent 4c5133f5

drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2933,13 +2933,15 @@ static long atomisp_vidioc_default(struct file file, void fh,
		#else
		if (isp->motor)
		#endif
		err = v4l2_subdev_call(
		#ifndef ISP2401
		err = v4l2_subdev_call(
		isp->inputs[asd->input_curr].motor,
		core, ioctl, cmd, arg);
		#else
		err = v4l2_subdev_call(
		isp->motor,
		#endif
		core, ioctl, cmd, arg);
		#endif
		else
		err = v4l2_subdev_call(
		isp->inputs[asd->input_curr].camera,

Admin message