Commit 5833112d authored Apr 03, 2020 by Christoph Hellwig Committed by Darrick J. Wong Apr 06, 2020

xfs: reflink should force the log out if mounted with wsync



Reflink should force the log out to disk if the filesystem was mounted
with wsync, the same as most other operations in xfs.

[Note: XFS_MOUNT_WSYNC is set when the admin mounts the filesystem
with either the 'wsync' or 'sync' mount options, which effectively means
that we're classifying reflink/dedupe as IO operations and making them
synchronous when required.]

Fixes: 3fc9f5e4 ("xfs: remove xfs_reflink_remap_range")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
[darrick: add more to the changelog]
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 54fbdd10

fs/xfs/xfs_file.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1059,7 +1059,11 @@ xfs_file_remap_range(

		ret = xfs_reflink_update_dest(dest, pos_out + len, cowextsize,
		remap_flags);
		if (ret)
		goto out_unlock;

		if (mp->m_flags & XFS_MOUNT_WSYNC)
		xfs_log_force_inode(dest);
		out_unlock:
		xfs_reflink_remap_unlock(file_in, file_out);
		if (ret)

Admin message