Commit 5831b333 authored Jun 30, 2020 by Colin Ian King Committed by David S. Miller Jun 30, 2020

net/mlx5e: fix memory leak of tls



The error return path when create_singlethread_workqueue fails currently
does not kfree tls and leads to a memory leak. Fix this by kfree'ing
tls before returning -ENOMEM.

Addresses-Coverity: ("Resource leak")
Fixes: 1182f365 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6bad912b

drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -232,8 +232,10 @@ int mlx5e_tls_init(struct mlx5e_priv *priv)
		return -ENOMEM;

		tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx");
		if (!tls->rx_wq)
		if (!tls->rx_wq) {
		kfree(tls);
		return -ENOMEM;
		}

		priv->tls = tls;
		return 0;

Admin message