Commit 5813da15 authored Oct 24, 2017 by Dan Carpenter Committed by Guenter Roeck Oct 29, 2017

hwmon: (max6621) Inverted if condition in max6621_read()

We intended to test for failure here but accidentally tested for
success. It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.

Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent a3bdc5b5

drivers/hwmon/max6621.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
		if (regval) {
		ret = i2c_smbus_write_byte(data->client,
		MAX6621_CLEAR_ALERT_REG);
		if (!ret)
		if (ret)
		return ret;
		}

Admin message