Commit 5809e18e authored by Dalit Ben Zoor's avatar Dalit Ben Zoor Committed by Oded Gabbay
Browse files

habanalabs: remove redundant member from parser struct 



use_virt_addr member was used for telling whether to treat the
addresses in the CB as virtual during parsing. We disabled it only
when calling the parser from the driver memset device function,
and since this call had been removed, it should always be enabled.

Signed-off-by: default avatarDalit Ben Zoor <dbenzoor@habana.ai>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 94cb669c

drivers/misc/habanalabs/command_submission.c

+0 −1
Original line number Diff line number Diff line
@@ -93,7 +93,6 @@ static int cs_parser(struct hl_fpriv *hpriv, struct hl_cs_job *job) 
	parser.user_cb_size = job->user_cb_size;

	parser.ext_queue = job->ext_queue;

	job->patched_cb = NULL;

	parser.use_virt_addr = hdev->mmu_enable;



	rc = hdev->asic_funcs->cs_parser(hdev, &parser);

	if (job->ext_queue) {

drivers/misc/habanalabs/goya/goya.c

+1 −1
Original line number Diff line number Diff line
@@ -3903,7 +3903,7 @@ int goya_cs_parser(struct hl_device *hdev, struct hl_cs_parser *parser) 
	if (!parser->ext_queue)

		return goya_parse_cb_no_ext_queue(hdev, parser);



	if ((goya->hw_cap_initialized & HW_CAP_MMU) && parser->use_virt_addr)

	if (goya->hw_cap_initialized & HW_CAP_MMU)

		return goya_parse_cb_mmu(hdev, parser);

	else

		return goya_parse_cb_no_mmu(hdev, parser);

drivers/misc/habanalabs/habanalabs.h

+0 −3
Original line number Diff line number Diff line
@@ -779,8 +779,6 @@ struct hl_cs_job { 
 * @patched_cb_size: the size of the CB after parsing.

 * @ext_queue: whether the job is for external queue or internal queue.

 * @job_id: the id of the related job inside the related CS.

 * @use_virt_addr: whether to treat the addresses in the CB as virtual during

 *			parsing.

 */

struct hl_cs_parser {

	struct hl_cb		*user_cb;
@@ -793,7 +791,6 @@ struct hl_cs_parser { 
	u32			patched_cb_size;

	u8			ext_queue;

	u8			job_id;

	u8			use_virt_addr;

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE