Commit 58066ac9 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

ptp_qoriq: don't pass a large struct by value but instead pass it by reference 



Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes
of data by value on the stack. Optimize this by passing it by reference instead.
Also shinks the object code size:

Before:
   text	   data	    bss	    dec	    hex	filename
  12596	   2160	     64	  14820	   39e4	drivers/ptp/ptp_qoriq.o

After:
   text	   data	    bss	    dec	    hex	filename
  12567	   2160	     64	  14791	   39c7	drivers/ptp/ptp_qoriq.o

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d2cf821f

drivers/net/ethernet/freescale/enetc/enetc_ptp.c

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static int enetc_ptp_probe(struct pci_dev *pdev, 


	ptp_qoriq->dev = &pdev->dev;



	err = ptp_qoriq_init(ptp_qoriq, base, enetc_ptp_caps);

	err = ptp_qoriq_init(ptp_qoriq, base, &enetc_ptp_caps);

	if (err)

		goto err_no_clock;

drivers/ptp/ptp_qoriq.c

+3 −3
Original line number Diff line number Diff line
@@ -459,7 +459,7 @@ static int ptp_qoriq_auto_config(struct ptp_qoriq *ptp_qoriq, 
}



int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,

		   const struct ptp_clock_info caps)

		   const struct ptp_clock_info *caps)

{

	struct device_node *node = ptp_qoriq->dev->of_node;

	struct ptp_qoriq_registers *regs;
@@ -468,7 +468,7 @@ int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base, 
	u32 tmr_ctrl;



	ptp_qoriq->base = base;

	ptp_qoriq->caps = caps;

	ptp_qoriq->caps = *caps;



	if (of_property_read_u32(node, "fsl,cksel", &ptp_qoriq->cksel))

		ptp_qoriq->cksel = DEFAULT_CKSEL;
@@ -605,7 +605,7 @@ static int ptp_qoriq_probe(struct platform_device *dev) 
		goto no_ioremap;

	}



	err = ptp_qoriq_init(ptp_qoriq, base, ptp_qoriq_caps);

	err = ptp_qoriq_init(ptp_qoriq, base, &ptp_qoriq_caps);

	if (err)

		goto no_clock;

include/linux/fsl/ptp_qoriq.h

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static inline void qoriq_write_le(unsigned __iomem *addr, u32 val) 


irqreturn_t ptp_qoriq_isr(int irq, void *priv);

int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,

		   const struct ptp_clock_info caps);

		   const struct ptp_clock_info *caps);

void ptp_qoriq_free(struct ptp_qoriq *ptp_qoriq);

int ptp_qoriq_adjfine(struct ptp_clock_info *ptp, long scaled_ppm);

int ptp_qoriq_adjtime(struct ptp_clock_info *ptp, s64 delta);

CRA Git | Maintained and supported by SUSTech CRA and CCSE